Linked js files are not downloaded from sketch

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.

https://editor.p5js.org

GNU Lesser General Public License v2.1

1.33k stars 1.29k forks source link

Linked js files are not downloaded from sketch #1099

Closed jareddonovan closed 5 years ago

jareddonovan commented 5 years ago

Nature of issue?

Found a bug

Details about the bug:

Chrome MacOSX

Steps to reproduce this bug:
- Open the following sketch: https://editor.p5js.org/creativecoding/sketches/ObakvEt8C
- The sketch contains several javascript files (cookie.js, spaceshipParts.js, etc.)
- Click 'download' from the 'file' menu
- The zip will download. Unzip it. It does not contain all javascript files. It only contains the p5js library files and sketch.js

catarak commented 5 years ago

thanks for reporting! i think this issue here is that the files (cookie.js, spaceshipParts.js, etc) are technically of type folder. the bigger issue is that users shouldn't be able to add text content to a folder, nor should a folder be able to have an extension. i think there's an open pr with respect to the former.

catarak commented 5 years ago

i just pushed a fix that will prevent users from adding text content to folders. however, this will break your sketch, so I made a copy of it that will work: https://editor.p5js.org/cassie/sketches/Id2Uu66Fz you'll need to duplicate this to get back your original!

jareddonovan commented 5 years ago

Thank you so much Cassie!