Feature Request: Private Option for Sketches

golanlevin commented 2 years ago

New feature request

New feature details:

Hi friends, I'm writing to re-open issues #91, #1604, and #1832 — a feature request for a "private" option for sketches. Sketches that have been set to Private would not be visible, unless their author was logged into the Editor in their browser.

Some reasons that an artist might want to set a sketch to Private could be that:

It is a work-in-progress, and they're not ready to 'publish' it
It is a solution for a homework that they're giving to their students
It's a scrap sketch or piece of test code that they don't want shown in their public gallery
The project deals with controversial themes, etc.
(NEW!!) The creator is concerned about theft by NFT copyminters

Like it or not, the NFT phenomenon has radically transformed the landscape of generative and algorithmic software art. P5.js is now widely used as a tool for making NFTs. While this has led to some income for our community, the monetization of generative art has also led to a lot of scammers, fake accounts, 'copyminting', and other foul play. Unfortunately, some unscrupulous people are trawling through various Editor accounts, gleaning projects and then selling them as NFTs. The requested feature would allow an artist to work on a sketch away from the prying eyes of NFT thieves.

I think the logical place to set a sketch to "Private" is in this menu:

Thanks for your consideration! <3 Golan

CarsonKompon commented 2 years ago

Bumping in hopes that there is a reconsideration

dhowe commented 1 year ago

This is really really needed

vivekbopaliya commented 9 months ago

@raclim how are you planning to tackle this?---simple if-else or even post request and complete server actions can be involved for more privacy imo

golanlevin commented 9 months ago

Hi friends — if there's any chance this is being considered, I'd be so happy. One UX implementation suggestion – I'm a fan of how YouTube has three privacy categories:

🟢 Public: publicly listed on the creator's page, and viewable to all.
🟡 Unlisted: not publicly listed on the creator's page, but viewable if the author has shared the URL with you.
🔴 Private: not publicly listed on the creator's page, and only viewable to the creator when they're logged in.

Best, Golan

golanlevin commented 4 months ago

If anyone's working on this, it would be a great feature to coincide with the 2.0 release of p5.js....

vivekbopaliya commented 4 months ago

If anyone's working on this, it would be a great feature to coincide with the 2.0 release of p5.js....

Hey, although I'm not quite sure about unlisted yet, the feature is coming along well. I have been working on and off over the past months. You can check out the preview and share your views and more ideas.

golanlevin commented 4 months ago

OH WOW! This is GREAT. You're a hero, Vivek! Thanks too to Raclim and others who've also contributed!

dhowe commented 4 months ago

super important feature... thanks all !

raclim commented 3 months ago

Just want to add here that we created a develop environment for @vivekbopaliya's PR to test this feature out! To see the feature:

Sign up for an account.
Once your account is created, save a sketch.
You should now be able to see the Private Option on both the 'My Sketches' page and the menu when the sketch is opened!

Menu When the Sketch is Opened

On the 'My Sketches' Page

Please feel free to add any suggestions here or if it seems good to go! Thanks!

golanlevin commented 3 months ago

Thanks for posting this! I've just made an account and have done a little testing. I've experienced some weird behavior:

Although I'm able to save sketches, the page reports "Failed to Save Sketch" and an Error alert, "The project you have attempted to save has been saved from another window. Please refresh the page to see the latest version." This happens regardless of whether or not I have checked 'Private'. I don't have the sketch (or my account) open in another window.
Regardless of the above warnings, I'm able to save a Private sketch. When I go to view my list of sketches, I see that sketch listed there, and the "Private" flag is set. However, when I then return to editing that sketch in the Editor — although my most recent changes to the code have not been lost! — the "Private" status has been lost.

I'm working in Safari in MacOS 14.5.

vivekbopaliya commented 3 months ago

@golanlevin could you please explain further how to reproduce this behaviour?

processing / p5.js-web-editor

Feature Request: Private Option for Sketches #1987

New feature details: