The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.
Currently you cannot run npm install to set up the development environment. You must run npm install --legacy-peer-deps. This could be confusing to new developers and make it harder to contribute.
Feature enhancement details
I'm creating this issue so that I can fix it.
npm install does not work in this repo right now due to a dependency conflict on the eslint package. We are using eslint version 7.31.0. However we are using an outdated version of eslint-config-airbnb which expects a much older version of eslint.
We have eslint-config-airbnb@^16.1.0 which expects a peer dependency of eslint@^4.9.0. We can fix the conflict by updating the eslint-config-airbnb package to its latest version which is in the 19.x range -- up 3 major versions. This has not been done previously because updating that package introduces lots of new rules and causes lots of code to fail linting checks. I opened #2217 to discuss the specifics of what new rules we like and don't like. In order to upgrade the package and fix the npm install conflict without changing lots of code, I recommend modifying the .eslintrc config to mimic the current rule conditions. We can then tackle rules one-by-one.
@lindapaiste while running "npm install --legacy-peer-deps" on linux, I am getting this error,
is this something related to my local machine or is there anything I am doing wrong
Sudarshan-21
commented
5 months ago
Increasing Access
Currently you cannot run
npm installto set up the development environment. You must runnpm install --legacy-peer-deps. This could be confusing to new developers and make it harder to contribute.Feature enhancement details
I'm creating this issue so that I can fix it.
npm installdoes not work in this repo right now due to a dependency conflict on theeslintpackage. We are usingeslintversion7.31.0. However we are using an outdated version ofeslint-config-airbnbwhich expects a much older version ofeslint.We have
eslint-config-airbnb@^16.1.0which expects a peer dependency ofeslint@^4.9.0. We can fix the conflict by updating theeslint-config-airbnbpackage to its latest version which is in the19.xrange -- up 3 major versions. This has not been done previously because updating that package introduces lots of new rules and causes lots of code to fail linting checks. I opened #2217 to discuss the specifics of what new rules we like and don't like. In order to upgrade the package and fix thenpm installconflict without changing lots of code, I recommend modifying the.eslintrcconfig to mimic the current rule conditions. We can then tackle rules one-by-one.