search

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.
https://editor.p5js.org
GNU Lesser General Public License v2.1
1.38k stars 1.32k forks source link

fixed the login and signup button #2755

Closed aditya123473892 closed 8 months ago

aditya123473892 commented 10 months ago

Fixes #2734

Changes: tried to enhance the login and signup buttons on the error modal that appears on saving the file instead of adding the borders i just changed the test color that makes it look more visible

Screenshot 2023-12-20 223557 I have verified that this pull request:

has no linting errors (npm run lint) has no test errors (npm run test) is from a uniquely-named feature branch and is up to date with the develop branch. is descriptively named and links to an issue number, i.e. Fixes #2734

welcome[bot] commented 10 months ago

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

raclim commented 8 months ago

Thanks for working on this! I'm going to close this for now due to reasons laid out in https://github.com/processing/p5.js-web-editor/issues/2734#issuecomment-1910940542. Please feel free to reopen to create a new issue regarding this once a solution/design has been finalized!