About page width updated

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.

https://editor.p5js.org

GNU Lesser General Public License v2.1

1.38k stars 1.32k forks source link

About page width updated #2756

Closed ABHIJITHDL closed 8 months ago

ABHIJITHDL commented 9 months ago

Fixes #2700

Changes: Updated the About Block width to prevent content overflowing on changing language. Before: Screenshot (68) After: Screenshot (69) I've tested this for all the languages.

I have verified that this pull request:

[X] has no linting errors (npm run lint)
[X] has no test errors (npm run test)
[X] is from a uniquely-named feature branch and is up to date with the develop branch.
[X] is descriptively named and links to an issue number, i.e. Fixes #2700

welcome[bot] commented 9 months ago

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

raclim commented 8 months ago

Thanks for submitting this! I think the solution we're looking for is closer to what's mentioned here, where we'd prefer to have the text within the column to wrap (https://github.com/processing/p5.js-web-editor/issues/2700#issuecomment-1847908197). At a first glance this change might be okay, but I feel hesitant to have something in that changes the size of the whole modal. I'm going to close this for now, but please feel free to resubmit this or check out the other issues!