About block style fix - Githubissues

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.

https://editor.p5js.org

GNU Lesser General Public License v2.1

1.38k stars 1.32k forks source link

About block style fix #2758

Closed Swarnendu0123 closed 8 months ago

Swarnendu0123 commented 9 months ago

Fixes #2700 Ref #2701

[x] About Block fixed for all the languages

Changes: Screenshot (51) Screenshot (52) Screenshot (53) Screenshot (54) Screenshot (55)

I have verified that this pull request:

[x] has no linting errors (npm run lint)
[x] has no test errors (npm run test)
[x] is from a uniquely-named feature branch and is up to date with the develop branch.
[x] is descriptively named and links to an issue number, i.e. Fixes #123

raclim commented 8 months ago

Thanks for submitting this!

I think the solution we're looking for is closer to what's mentioned here, where we'd prefer to have the text within the column to wrap (https://github.com/processing/p5.js-web-editor/issues/2700#issuecomment-1847908197). I think there's also some other changes in here as well (such as adding links to the version number) that we'd want to keep separated from this issue's fix. I'm going to close this for now, but please feel free to resubmit this with any changes!

Swarnendu0123 commented 8 months ago

Thanks for submitting this!

I think the solution we're looking for is closer to what's mentioned here, where we'd prefer to have the text within the column to wrap (https://github.com/processing/p5.js-web-editor/issues/2700#issuecomment-1847908197). I think there's also some other changes in here as well (such as adding links to the version number) that we'd want to keep separated from this issue's fix. I'm going to close this for now, but please feel free to resubmit this with any changes!

Great! I will constantly look towards issues. Thanks.