search

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.
https://editor.p5js.org
GNU Lesser General Public License v2.1
1.38k stars 1.32k forks source link

Update user.controller.js Fixing the error of ignoring the ERROR case… #2768

Closed koushik-dasss closed 9 months ago

koushik-dasss commented 9 months ago

Using return promise logic of JS to get the ERROR CASES fixed without ignoring like the current code does . Fixes IGNORANCE OF ERROR CASES by adding return promise method .

Screenshot 2023-12-24 112207
lindapaiste commented 9 months ago

Copying my comment from #2772 because this PR has the same issue.

The changes to the function look good. You’ve changed the signature of the function so that it no longer accepts a callback as an argument. So you need to make sure that you have updated all the places where this function is used so that the work with an async/promise call instead of passing a callback.