Fixed #2647, fixed overlay button blue border-box!

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.

https://editor.p5js.org

GNU Lesser General Public License v2.1

1.38k stars 1.32k forks source link

Fixed #2647, fixed overlay button blue border-box! #2783

Closed vivekbopaliya closed 7 months ago

vivekbopaliya commented 9 months ago

Fixes #2647, Position of cross in about modal is now aligned center in blue border box.

Before: Screenshot (174)

Changes: Screenshot (175)

I have verified that this pull request:

[x] has no linting errors (npm run lint)
[x] has no test errors (npm run test)
[x] is from a uniquely-named feature branch and is up to date with the develop branch.
[x] is descriptively named and links to an issue number, i.e. Fixes #123

vivekbopaliya commented 9 months ago

OH YES GOOD CALL! there always have to be multiple solutions to this as i didn't try many things with.overlay_header, but around time, when i was trying to center the blue box, it ended up having more space on the left. So, I added a bit of padding around the button and justify-item center.

Your solution looks cleaner than mine. Go ahead with it.

Thanks for the pictures.

raclim commented 7 months ago

Thank you for your work on this!

Due to recent updates, I'm ultimately going to close this due to the reasons laid out in https://github.com/processing/p5.js-web-editor/issues/2647#issuecomment-2004694237. I'm really sorry we couldn't get this in, but please be on the lookout for the new designs!