processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.
https://editor.p5js.org
GNU Lesser General Public License v2.1
1.38k stars 1.32k forks source link

text colour not changing in dark/high contrast theme in ```describe()``` #2785

Closed Hemant2A2 closed 2 months ago

Hemant2A2 commented 9 months ago

p5.js version

1.9.0

What is your operating system?

Mac OS

Web browser and version

Chrome , Version 120.0.6099.109 (Official Build) (arm64)

Actual Behavior

when the LABEL is passed in describe() the text colour is not changed when switched to dark/high contrast theme.

Light theme:

Screenshot 2023-12-26 at 4 04 36 PM

Dark theme:

Screenshot 2023-12-26 at 4 05 03 PM

Expected Behavior

The text colour should toggle as the user switches between light and dark theme

Steps to reproduce

Steps:

  1. Go to https://editor.p5js.org/ and paste the below code in the editor ( or any other code which uses describe())

    Snippet:

function setup() { background('pink');

// Draw a heart. fill('red'); noStroke(); circle(67, 67, 20); circle(83, 67, 20); triangle(91, 73, 75, 95, 59, 73);

// Add a general description of the canvas // and display it for debugging. describe('A pink square with a red heart in the bottom-right corner.', LABEL); }

welcome[bot] commented 9 months ago

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

sdivyanshu90 commented 9 months ago

Hi, @Hemant2A2, thanks for reporting this issue. In my view, this problem is related to p5.js rather than p5.js-web-editor.

lindapaiste commented 9 months ago

We have another issue regarding making the sketch background be white regardless of the theme. That would also fix this. See #1852

somesh4747 commented 9 months ago

@raclim @lindapaiste I have tried to fix the issue #2785, check this #2801

Noorain464 commented 2 months ago

@raclim @Hemant2A2 I would like to work on this issue