Use styled-components in CollectionListRow

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.

https://editor.p5js.org

GNU Lesser General Public License v2.1

1.38k stars 1.32k forks source link

Use styled-components in CollectionListRow #2799

Closed adityagarg06 closed 4 months ago

adityagarg06 commented 9 months ago

Progress on #1760

Changes:

Migrate styles from client/styles/components/_sketch_list.scss into individual styled components in the client/modules/IDE/components/CollectionList/CollectionListRow.jsx file.
Looks identical to before on Windows Chrome.

I have verified that this pull request:

[x] has no linting errors (npm run lint)
[x] has no test errors (npm run test)
[x] is from a uniquely-named feature branch and is up to date with the develop branch.
[x] is descriptively named and links to an issue number, i.e. Fixes #123

lindapaiste commented 9 months ago

This looks good at first glance. I wonder how it works alongside some of the pending PRs that I have re: common table components. I noticed that you didn't delete the classes from the .scss file. Possibly because they are used in multiple places? We have the same styles on multiple tables so possibly the conversion to styled-components becomes part of creating a common table component/system, where we have a TableBase with the core styles that can be extended or overwritten for specific tables.