The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.
This does not change any UI anywhere in the app. It removes some unused code and enables us to use the <Button> component inline in the future. There is more that could be refactored and cleaned up but I'm keeping this PR minimal.
Changes:
Modify the core StyledButton component to use either display: inline-flex or display: flex, depending on the value of the display prop.
Deleted the StyledIconButton component which was not used anywhere. Confusingly, the existing IconButton component which we use on mobile is an extension of the StyledInlineButton rather than the StyledIconButton.
Maintain the styles of the current IconButton component by passing down the prop iconOnly and using this prop to switch components rather than switching based on the display prop.
I have verified that this pull request:
[x] has no linting errors (npm run lint)
[x] has no test errors (npm run test)
[x] is from a uniquely-named feature branch and is up to date with the develop branch.
[x] is descriptively named and links to an issue number, i.e. Fixes #123
Fixes #2821
This does not change any UI anywhere in the app. It removes some unused code and enables us to use the
<Button>component inline in the future. There is more that could be refactored and cleaned up but I'm keeping this PR minimal.Changes:
StyledButtoncomponent to use eitherdisplay: inline-flexordisplay: flex, depending on the value of thedisplayprop.StyledIconButtoncomponent which was not used anywhere. Confusingly, the existingIconButtoncomponent which we use on mobile is an extension of theStyledInlineButtonrather than theStyledIconButton.IconButtoncomponent by passing down the propiconOnlyand using this prop to switch components rather than switching based on thedisplayprop.I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123