Update theme.js - Githubissues

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.

https://editor.p5js.org

GNU Lesser General Public License v2.1

1.38k stars 1.32k forks source link

Update theme.js #2825

Closed RohitPaul0007 closed 9 months ago

RohitPaul0007 commented 9 months ago

Fixes #issue-number

Changes:

I have verified that this pull request:

[x] has no linting errors (npm run lint)
[x] has no test errors (npm run test)
[x] is from a uniquely-named feature branch and is up to date with the develop branch.
[x] is descriptively named and links to an issue number, i.e. Fixes #123

welcome[bot] commented 9 months ago

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

RohitPaul0007 commented 9 months ago

can some one see the PR and give me feedback?

lindapaiste commented 9 months ago

can some one see the PR and give me feedback?

I think that you misunderstood the intention of the issue #2823. What you have done here is changed the pinks to yellows. We have 3 different themes, "light" "dark" and "contrast". We use pink as the primary accent color on "light" and "dark" and yellow as the primary accent color for "contrast". We definitely don't want to change that. We want to use a darker pink as the hover color for the "light" and "dark" themes and a darker yellow as the hover color for the "contrast" theme.