search

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.
https://editor.p5js.org
GNU Lesser General Public License v2.1
1.38k stars 1.32k forks source link

Fixed the horizotal page scroll issue for smaller usernames #2828

Closed Sudarshan-21 closed 4 months ago

Sudarshan-21 commented 9 months ago

Fixes #2678

Changes: For resolving this issue there were many design ideas i thought:

  1. providing padding or margin so that we will be able to stop the overflow of the dropdown. But crating blank space in the right side of that element would look bad.
  2. alignning the dropdown menu right would be another option but as mentioned in the following comment I dropped this idea https://github.com/processing/p5.js-web-editor/issues/2678#issuecomment-1839258617
  3. So, the better option was to use different style of dropdown menu Screenshot from 2024-01-02 02-22-19 Screenshot from 2024-01-02 02-21-46 So for the longer usernames it stays as before, but for short usernames it shrinks itself below the username.

4.Another proposed idea is to interchange the postion of the language dropdown and username dropdown. @lindapaiste I would like to have your review of my currently created and 4th proposed idea.

I have verified that this pull request:

release-com[bot] commented 9 months ago

Release Environments

This Environment is provided by Release, learn more! To see the status of the Environment click on Environment Status below.

:wrench:Environment Status : https://app.release.com/public/Processing%20Foundation/env-f155cff815

raclim commented 4 months ago

Thanks for your work on this! I think this solution doesn't exactly address the original issue, which was referring to the position of the dropdown element affecting the console, rather than the dropdown's overflow, which is somewhat of a separate issue! I think this change might not be what we're looking for, so I'm going to close this for now. I'm sorry that we couldn't get this in, but please feel free to check out our other issues!