search

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.
https://editor.p5js.org
GNU Lesser General Public License v2.1
1.38k stars 1.32k forks source link

Fix: Support modal responsiveness on mobile devices #2830

Closed Sanjay-Sahu-Bandla closed 6 months ago

Sanjay-Sahu-Bandla commented 9 months ago

Issue:

The Support modal exhibited horizontal scrolling on mobile devices due to a fixed width.

Solution:

Resolved by adjusting the modal's width property from a fixed value to max-width, enabling responsiveness based on content. This ensures optimal viewing on various screen sizes, enhancing user experience. Furthermore, the font size of the 'Contribute and learn more!' button is adjusted for optimal readability on mobile devices.

Changes:

Before p5-js-Web-Editor-Before (1)

After

p5-js-Web-Editor-After

I have verified that this pull request:

sdivyanshu90 commented 9 months ago

Hi @Sanjay-Sahu-Bandla, Greetings. Please refer to this comment: https://github.com/processing/p5.js-web-editor/issues/2760#issuecomment-1870394333.

raclim commented 6 months ago

Thanks for raising this issue! The issue this PR is resolving is for a temporary modal that we've now removed from the editor, so I'm going to close this PR as it no longer exists. We're probably going to release a new fundraiser at the end of this year, so that could be a potential issue to work on next in the future!