search

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.
https://editor.p5js.org
GNU Lesser General Public License v2.1
1.38k stars 1.32k forks source link

Refactoring Searchbar from class component to functional component. Enhancement #2832

Closed Shyam-Raghuwanshi closed 9 months ago

Shyam-Raghuwanshi commented 9 months ago

Increasing Access

Unsure

Feature enhancement details

Feature enhancement details The Searchbar component still uses class based component structure. Changing it to functional based component would simplify the state management and maintainability of code along with being consistent with modern react

welcome[bot] commented 9 months ago

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

lindapaiste commented 9 months ago

Hey we have like 7 different PRs for converting the component. The complex part is properly memoizing the throttle and a lot of the PRs didn't do that part properly. I need to review them all and find one which handles it best.

lindapaiste commented 9 months ago

In the meantime I'm going to close this because we don't need any additional PRs.