convert searchbar class component to function component

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.

https://editor.p5js.org

GNU Lesser General Public License v2.1

1.38k stars 1.32k forks source link

convert searchbar class component to function component #2835

Closed Shyam-Raghuwanshi closed 7 months ago

Shyam-Raghuwanshi commented 9 months ago

Fixes #2832

Changes: converting Searchbar class component to function component

I have verified that this pull request:

[X] has no linting errors (npm run lint)
[X] has no test errors (npm run test)
[X] is from a uniquely-named feature branch and is up to date with the develop branch.
[X] is descriptively named and links to an issue number, i.e. Fixes #123

raclim commented 7 months ago

Thanks for submitting this!

I don't think the throttling is being handled correctly on line 24, and we'd ideally want to keep lodash import that was removed on line 3. Since there's a couple other pull requests that have already been submitted for the Searchbar, I'm going to close this for now, but please feel free to update this PR or check out other issues!