Fixed the issue cannot create a SharedArrayBuffer

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.

https://editor.p5js.org

GNU Lesser General Public License v2.1

1.38k stars 1.32k forks source link

Fixed the issue cannot create a SharedArrayBuffer #2851

Closed goutamdh closed 3 months ago

goutamdh commented 9 months ago

Fixes #2094

Changes: Set Cross-Origin-Embedder-Policy and Cross-Origin-Opener-Policy headers This commit adds security headers to the server response to enable cross-origin isolation for shared memory operations in the p5.js editor. I have verified that this pull request:

[x] has no linting errors (npm run lint)
[x] has no test errors (npm run test)
[x] is from a uniquely-named feature branch and is up to date with the develop branch.
[x] is descriptively named and links to an issue number, i.e. Fixes #123

welcome[bot] commented 9 months ago

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

raclim commented 3 months ago

Thanks for your work on this! After testing this, I don't think what's here is the complete solution yet since the issue seems to still persist on my end! I don't exactly know what the right resolution looks like myself, but I feel like what's here is probably going in that vein. Since we have quite a few PRs open at the moment I'm going to close this one for now. I'm sorry that we couldn't get this one in, but please feel free to reopen this with any updates or check out our other issues!