search

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.
https://editor.p5js.org
GNU Lesser General Public License v2.1
1.38k stars 1.32k forks source link

the translation feature for the string which is top in nav bar is not working #2865

Closed shivapranav07 closed 9 months ago

shivapranav07 commented 9 months ago

p5.js version

No response

What is your operating system?

Windows

Web browser and version

No response

Actual Behavior

the text which is on the nav bar is not changing when we change the language

issue3

Expected Behavior

the language must be changed to the selected language

Steps to reproduce

Steps:

    1. 3.

      Snippet:

// Paste your code here :)

welcome[bot] commented 9 months ago

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

KartikChawla09 commented 9 months ago

I would like to work on the issue! Please assign it to me!

shivapranav07 commented 9 months ago

actually i am working on this issue !

KartikChawla09 commented 9 months ago

actually i am working on this issue !

Oh, I have already executed the modification and was in the process of preparing a pull request. Nevertheless, please feel free to proceed with your work on the given issue.

shivapranav07 commented 9 months ago

Actually it is my fst tym doing open source i have sorted the issue if it doesnt work feel free to override my pull req

On Sun, 7 Jan 2024 at 6:33 PM, Kartik Chawla @.***> wrote:

actually i am working on this issue !

Oh, I have already executed the modification and was in the process of preparing a pull request. Nevertheless, please feel free to proceed with your work on the given issue.

— Reply to this email directly, view it on GitHub https://github.com/processing/p5.js-web-editor/issues/2865#issuecomment-1880054316, or unsubscribe https://github.com/notifications/unsubscribe-auth/BENWBHJRH4WXF6XAUBVQDYDYNKMKLAVCNFSM6AAAAABBQIUQ52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBQGA2TIMZRGY . You are receiving this because you authored the thread.Message ID: @.***>

shivapranav07 commented 9 months ago

@lindapaiste can you please review my pull req

harmanbatheja15 commented 9 months ago

I think there is no issue there. The translation for that text is not added in the particular languages. @lindapaiste Can you confirm I am right or not?

shivapranav07 commented 9 months ago

Yes, they have used the keyword "Fundraiser," but it appears that the translation for that term has not been added in any language. Am I correct @harmanbatheja15 ?

harmanbatheja15 commented 9 months ago

Yes, they have used the keyword "Fundraiser," but it appears that the translation for that term has not been added in any language. Am I correct @harmanbatheja15 ?

Yes

shivapranav07 commented 9 months ago

I have added the translation of that term to every language present in the p5.js Web Editor and created a pull request for it. @harmanbatheja15 @lindapaiste

harmanbatheja15 commented 9 months ago

I have added the translation of that term to every language present in the p5.js Web Editor and created a pull request for it. @harmanbatheja15 @lindapaiste

I think you should not add the translations using Google Translator. As we can't check if the translations are correct or not.

shivapranav07 commented 9 months ago

Is there an alternative method to Google Translate that you could suggest? Your guidance would be beneficial to me.

I have added the translation of that term to every language present in the p5.js Web Editor and created a pull request for it. @harmanbatheja15 @lindapaiste

I think you should not add the translations using Google Translator. As we can't check if the translations are correct or not.

raclim commented 9 months ago

Thanks for raising this issue!

We're planning to take down this text since it was meant to be a temporary promotion for the 2023 fundraiser until January 15th. Since I just reverted the fundraiser PR and the next release is going to be on January 16th, we're not going to merge in further changes to the fundraiser modal for now.

The past few PRs definitely did raise some issues with the 2023 implementation (such as mobile responsiveness and adding translations)—hopefully many of these can be addressed for 2024!