Closed arpitghura closed 6 months ago
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.
min-inline-size: max-content;
on line 27 makes the keyboard shortcut command always have the max-content width, which means the content will not wrap on smaller screen sizes.Before
After
The second change is not particularly intended for the issue, but this can improve the readability. If you don't want this change, I will remove it.
I really like this!
Closing due to reasons laid out on https://github.com/processing/p5.js-web-editor/issues/2866#issuecomment-2027397824, but definitely wouldn't have been able to get there without your suggestions and finding the issue!
Fixes #2866
Changes:
max-width: #{500 / $base-font-size}rem;
on line 5, which makes the content in the list items have a maximum width instead of a width. This prevents the overflow of content on smaller screen sizes. Below is the attached screenshot of this:Before
After
min-inline-size: max-content;
on line 27 makes the keyboard shortcut command always have the max-content width, which means the content will not wrap on smaller screen sizes.Before
After
The second change is not particularly intended for the issue, but this can improve the readability. If you don't want this change, I will remove it.
I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123