search

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.
https://editor.p5js.org
GNU Lesser General Public License v2.1
1.38k stars 1.32k forks source link

fixed the greying image issue that occurs after uploading jpg image #2603 #2894

Closed aditya123473892 closed 4 months ago

aditya123473892 commented 9 months ago

Fixes #issue-number

Changes: This will fix the error of resizing the window uploaded image gets greyed out and shifts to bottom #2603

I have verified that this pull request:

has no linting errors (npm run lint) has no test errors (npm run test) is from a uniquely-named feature branch and is up to date with the develop branch. is descriptively named and links to an issue number, i.e. Fixes #2603

lindapaiste commented 9 months ago

I wonder if there are any unintended consequences from applying the entire desktop .editor-holder style to the mobile version?

The part that we need is: https://github.com/processing/p5.js-web-editor/blob/25067be796b83257d35f18f0546c49f86b533ace/client/styles/components/_editor.scss#L378-L380

The part that I'm concerned about is: https://github.com/processing/p5.js-web-editor/blob/25067be796b83257d35f18f0546c49f86b533ace/client/styles/components/_editor.scss#L371-L377

raclim commented 4 months ago

Thanks for your work on this! I don't think this solution succinctly addresses the issue here, so I'm going to close this for now. I'm sorry that we couldn't get this in, but please feel free to create another PR with an updated solution or check out our other issues!