Fixes Clicking on cross icon on create folder/create file modal throws unnessary error.

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.

https://editor.p5js.org

GNU Lesser General Public License v2.1

1.34k stars 1.29k forks source link

Fixes Clicking on cross icon on create folder/create file modal throws unnessary error. #2896

Closed iamnithishraja closed 7 months ago

iamnithishraja commented 7 months ago

Fixes #2895

Changes: Clicking on cross icon or whitespace on create folder/create file modal not dosen't throw any validation error message.

I have verified that this pull request:

[x] has no linting errors (npm run lint)
[x] has no test errors (npm run test)
[x] is from a uniquely-named feature branch and is up to date with the develop branch.
[x] is descriptively named and links to an issue number, i.e. Fixes #2895

lindapaiste commented 7 months ago

I don’t think that this is the right approach here. It looks like you are removing the “enter name” error message entirely. We would still want to show that error message if the user hits the submit button. What we want to do is tweak when the error shows so that it shows if the user is trying to submit the form in an invalid state but not if they are trying to close the form.