Feat: Give Preferred language based Credential Error from Backend

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.

https://editor.p5js.org

GNU Lesser General Public License v2.1

1.34k stars 1.29k forks source link

Feat: Give Preferred language based Credential Error from Backend #2898

Closed Vishal2002 closed 1 month ago

Vishal2002 commented 7 months ago

Fixes #2860

Changes:

Added i18next in the backend to automatically determine the language and map the correct error credential message.
In the Nav.jsx component, a backend request is sent to the endpoint /getCurrentLanguage to store the current language. The language is then changed using i18n.changeLanguage(language);.
Utilized i18nextMiddleware to capture the language and facilitate mapping errors accordingly.

I have verified that this pull request:

[x] has no linting errors (npm run lint)
[x] has no test errors (npm run test)
[x] is from a uniquely-named feature branch and is up to date with the develop branch.
[x] is descriptively named and links to an issue number, i.e. Fixes #2860

welcome[bot] commented 7 months ago

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

lindapaiste commented 7 months ago

This shows a lot of potential! Translating server-side messages is something that we've been discussing for a long time. See #1587

Vishal2002 commented 7 months ago

This shows a lot of potential! Translating server-side messages is something that we've been discussing for a long time. See #1587

What to do next?

raclim commented 1 month ago

Thanks so much for your work on this!

Due to some of the changes here falling out of date and some of the other features/fixes we'd like to prioritize over the next two months, I'm going to close this pull request for now. I'm really sorry that it took a while to get to this and that we couldn't get this in at the moment, but please feel free to update and reopen this pull request in the future!