search

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.
https://editor.p5js.org
GNU Lesser General Public License v2.1
1.34k stars 1.29k forks source link

Not able to scroll the Privacy policy, Terms of use, and Code of conduct pages in mobile view #2905

Closed haarsh157 closed 4 months ago

haarsh157 commented 7 months ago

p5.js version

2.10.2

What is your operating system?

None

Web browser and version

No response

Actual Behavior

Cannot scroll the Privacy policy, Terms of use, and Code of conduct pages in mobile view

https://github.com/processing/p5.js-web-editor/assets/115213858/baf4d282-b183-4ad6-8b60-dab59b0a15e4

Expected Behavior

The Privacy Policy, Terms of Use, and Code of Conduct pages should be scrolled to the end.

Steps to reproduce

Steps:

  1. Open mobile view.
  2. Go to about section then to Privacy Policy or Terms of Use or Code of Conduct page.
  3. Try to scroll through the page.
haarsh157 commented 7 months ago

Hi @lindapaiste , I would like to work on this issue

lindapaiste commented 7 months ago

Hi @lindapaiste , I would like to work on this issue

Sure, we definitely want to fix this!

lindapaiste commented 7 months ago

There's probably a few valid ways to fix this, with differences in what content is fixed to the top. One way would be in the PolicyContainer. We would add an overflow: auto and remove the min-height: 100vh; when in the mobile view.

raclim commented 5 months ago

I'm going to reopen this again since it wasn't fully resolved, which is explained in this comment: https://github.com/processing/p5.js-web-editor/pull/2930#issuecomment-2018615999!