search

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.
https://editor.p5js.org
GNU Lesser General Public License v2.1
1.34k stars 1.29k forks source link

Adding rounded edges to Contract/Expand Sidebar button & aligning sidebar header with editor header. #2909

Closed Ri-Sharma closed 5 months ago

Ri-Sharma commented 7 months ago

Increasing Access

This enhancement will enhance the user interface.

Feature enhancement details

Before :- image

After :- image

@lindapaiste, If this enhancement is approved, I am eager to contribute to its implementation.

raclim commented 7 months ago

Thanks for suggesting this! I think that to keep all the button elements throughout the whole editor consistent, it might be better to have the border-radius of the Sketch Files icon to match the border-radius of the other elements. Maybe like this?

Screenshot with border radius added to Sketch Files icon


A part of myself is also wondering if it might be okay to drop the background-color altogether (pictured below), but this also might not be consistent with the other button elements. I think this was a part of the mobile implementation, so I'm not as familiar with its design. @lindapaiste @dewanshDT do either of you have any thoughts on this?

Screenshot of Sketch Files icon without grey background
raclim commented 5 months ago

Thanks again for suggesting this!

After thinking about it, I feel a little hesitant to introduce to many new changes to the UI and think it would be best to approach these intentionally to ensure that we have other factors buttressing these changes in hand with aesthetic. I think there's a few other issues that reference the Sidebar as well, so I'm thinking it might be better to revisit this with maybe a larger redesign or encompassing issue for it (like the About). Until then, I'm going to close this and its affiliated PR for now!