Add checksum for JavaScript files on external CDN

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.

https://editor.p5js.org

GNU Lesser General Public License v2.1

1.34k stars 1.29k forks source link

Add checksum for JavaScript files on external CDN #2919

Closed davel closed 2 months ago

davel commented 7 months ago

Fixes #2918

Changes:

Adds integrity and crossorigin attributes for the p5.js JavaScript assets. The latter is necessary to cause browsers to check the checksum.

I have verified that this pull request:

[x] has no linting errors (npm run lint)
[x] has no test errors (npm run test)
[x] is from a uniquely-named feature branch and is up to date with the develop branch.
[x] is descriptively named and links to an issue number, i.e. Fixes #123

welcome[bot] commented 7 months ago

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

raclim commented 2 months ago

Closing due to reasons outlined in this comment in the associated issue!