Feature/ added create-collection Button in Add to Collection

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.

https://editor.p5js.org

GNU Lesser General Public License v2.1

1.34k stars 1.29k forks source link

Feature/ added create-collection Button in Add to Collection #2924

Closed KrishavRajSingh closed 3 months ago

KrishavRajSingh commented 7 months ago

Fixes #2505

Changes: Added create-collection Button in Add to Collection

https://github.com/processing/p5.js-web-editor/assets/99531396/e8df5382-d180-4575-a5b0-18315d89fc1f

I have verified that this pull request:

[x] has no linting errors (npm run lint)
[x] has no test errors (npm run test)
[x] is from a uniquely-named feature branch and is up to date with the develop branch.
[x] is descriptively named and links to an issue number, i.e. Fixes #123

raclim commented 3 months ago

Thanks for your work on this!

I feel like the user experience laid out here might be a bit overwhelming to navigate due to the double modals, and would not be friendly to screen-readers. I think this issue might need a design first before getting implemented, so I'm going to close this PR for now. I'm sorry that we couldn't get this in, but please feel free to reopen a new one once a design for this is decided, or check out our other issues!