fixed scroll - Githubissues

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.

https://editor.p5js.org

GNU Lesser General Public License v2.1

1.37k stars 1.32k forks source link

fixed scroll #2930

Closed rahulrangers closed 6 months ago

rahulrangers commented 8 months ago

Fixes #2905

Changes:

@lindapaiste I have verified that this pull request:

https://github.com/processing/p5.js-web-editor/assets/127782777/87a45f28-1d4f-41cb-995d-454acc19b9f4

[x] has no linting errors (npm run lint)
[x] has no test errors (npm run test)
[x] is from a uniquely-named feature branch and is up to date with the develop branch.
[x] is descriptively named and links to an issue number, i.e. Fixes #123

welcome[bot] commented 8 months ago

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

raclim commented 6 months ago

Sorry about that, after taking a closer look I realized I didn't carefully look at which particular files were being changed! I think this PR is still good for review!

lindapaiste commented 6 months ago

@raclim the min-height: 100vh which was removed in this PR was previously put in to prevent jumpiness on the desktop view when the fetch for the .md file finishes and the content comes in. Setting min-height: 100vh forces the scrollbar to be present at all times so that it won't disappear and reappear. You can find the issues. IMO we want to keep that when on desktop, but apply it conditionally using a media query. That's what I meant by my suggestion (emphasis added)

There's probably a few valid ways to fix this, with differences in what content is fixed to the top. One way would be in the PolicyContainer. We would add an overflow: auto and remove the min-height: 100vh; when in the mobile view.

raclim commented 6 months ago

@lindapaiste Ohh I see, sorry I did notice the distinction for only the mobile view but didn't realize the reasoning behind it and assumed it seemed okay. I'll reopen the issue and can update this PR with the needed changes!

beccyabraham commented 5 months ago

It looks like those pages still don't scroll all the way down on mobile; on the Privacy Policy page, I can't see the "Contact information" section