Fix : [#2866] Change width to 100%

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.

https://editor.p5js.org

GNU Lesser General Public License v2.1

1.32k stars 1.27k forks source link

Fix : [#2866] Change width to 100% #2932

Closed Ri-Sharma closed 3 months ago

Ri-Sharma commented 6 months ago

Fixes #2866

Changes:- The changes are made in _keyboard-shortcuts.scss

Changed width to 100% to resolve the issue.
Added min-inline-size: max-content; to prevent the wrapping of the keyboard shortcut commands.

I have verified that this pull request:

[x] has no linting errors (npm run lint)
[x] has no test errors (npm run test)
[x] is from a uniquely-named feature branch and is up to date with the develop branch.
[x] is descriptively named and links to an issue number.

raclim commented 3 months ago

Thanks for your work here on this!

I think I would change the width here to max-width to keep the placement of the scrollbar consistent with its current placement, which has some padding between the scrollbar and end of the modal (bottom image), as opposed to being on the far right (top image). I might go ahead with this change!

Besides that, I think I'd be down to get this in!