processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.
https://editor.p5js.org
GNU Lesser General Public License v2.1
1.32k stars 1.27k forks source link

Run accessibility checks in dev mode using `@axe-core/react` #2966

Open lindapaiste opened 5 months ago

lindapaiste commented 5 months ago

Increasing Access

Helps us find and fix accessibility issues before they make it into production.

Feature enhancement details

The official React docs recommend using the @axe-core/react to identify accessibility issues. https://legacy.reactjs.org/docs/accessibility.html#axe-axe-core-and-react-axe https://github.com/dequelabs/axe-core-npm/tree/develop/packages/react

We already have some checking with eslint ally, but this adds additional checks for insufficient color contrast, etc.

lindapaiste commented 5 months ago

I'm having issues with the package.json right now, so I'll past some stuff here which I intended to put in the PR.

We will get messages in the console when running in dev mode: image

Messages can be expanded to show more details about the error: image image

raclim commented 5 months ago

This would be awesome to add, thanks for finding this!

letscodedanish commented 5 months ago

Hi @lindapaiste @raclim ,

I noticed that our project could benefit from improved accessibility, and I'd like to propose a solution to address this issue.

Solution Proposal:

I suggest integrating accessibility checks using @axe-core/react into our project. This library will help us identify and fix accessibility issues before they make it into production.

Benefits:

Implementation Details:

We can install @axe-core/react as a development dependency and add a script to run accessibility checks on our React components.

Offer to Implement:

I'm willing to take on the task of implementing this solution if it aligns with our project goals.

Looking forward to your feedback and guidance on this proposal.

lindapaiste commented 5 months ago

@letscodedanish sure! I was going to do this myself but got distracted with other things.