search

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.
https://editor.p5js.org
GNU Lesser General Public License v2.1
1.32k stars 1.27k forks source link

Semantic HTML issues in header section #2967

Closed lindapaiste closed 1 month ago

lindapaiste commented 5 months ago

Increasing Access

Using proper semantic HTML allows screen readers to understand our content.

Feature enhancement details

I found two issues relating to the header section while running an accessibility check:

  1. We have a <header> element inside another <header> element, and multiple <header> elements on mobile. We need to get this down to one. We can change incorrect ones to either a React Fragment or a <div> or potentially remove them from the tree entirely.
  2. We have a <span> as a direct child of a <ul> in the "login or signup" part of the nav bar. Probably we change the <span>or</span> to <li>or</li>. It would also be acceptable to have the entire "login or signup" as one list item, but making the "or" into its own list item is probably easier to implement.

We want to fix these HTML structures without changing the style.

vaishnavi192 commented 5 months ago

@lindapaiste for issues which have PR linked with them are considered as closed right?

asimdelvi commented 3 months ago

Can you assign me this issue?

Simran-Sunil commented 2 months ago

Can I work on this issue?

Bhavyabhardwaj commented 2 months ago

anyone working on this issue ? if not can i work on this....?