Refactored CollectionList and CollectionListRow

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.

https://editor.p5js.org

GNU Lesser General Public License v2.1

1.37k stars 1.32k forks source link

Refactored CollectionList and CollectionListRow #2971

Closed vivekbopaliya closed 6 months ago

vivekbopaliya commented 8 months ago

Related to #2179 and #824

Changes:

Migrated CollectionList into functional component
Shifted them from props drilling to redux hooks

I have verified that this pull request:

[x] has no linting errors (npm run lint)
[x] has no test errors (npm run test)
[x] is from a uniquely-named feature branch and is up to date with the develop branch.
[x] is descriptively named and links to an issue number, i.e. Fixes #123

vivekbopaliya commented 8 months ago

This looks pretty good for the most part, but we have some other proposed changes to the CollectionList component which will definitely conflict so I don't know what the plan is. #2376

Ahhhhh, it appears that several components were optimized along with two new Table and TableRow have been added. i didn't check the PR. my bad. although as it is pretty huge PR and i see it is in still development (as some of test cases got failed ;) ) hence, we are not sure when will it get merged as yet. in meantime, i am moving forward and fix the changes that you requested.

vivekbopaliya commented 8 months ago

Additionally, we might want to seperate SketchListRow from SketchList and place it in its own file. I have worked on it and almost did wrap up migrating them into functional components and importing individual actions rather than prop drilling but eventually, it boiled down to failing one of 20 test errors even tho both components are completely working. I think while refactoring them, we will have to rewrite SketchList.unit.test component as well.

Although I have never worked on testing before 😬, let me know if you want me to raise a PR, and we can further discuss what changes are required in the unit test component. (could be a mini collab?!)

lindapaiste commented 8 months ago

This looks pretty good for the most part, but we have some other proposed changes to the CollectionList component which will definitely conflict so I don't know what the plan is. #2376

Ahhhhh, it appears that several components were optimized along with two new Table and TableRow have been added. i didn't check the PR. my bad. although as it is pretty huge PR and i see it is in still development (as some of test cases got failed ;) ) hence, we are not sure when will it get merged as yet. in meantime, i am moving forward and fix the changes that you requested.

Yeah everything regarding the list/table components has been kind of up in the air due to this major rewrite which has been in the works for a long time.

raclim commented 6 months ago

Thanks so much for submitting this and I'm sorry it took a while to get to this!

Although it's a bigger PR, it does address a lot of the refactoring needs so I think we ultimately might want to go with https://github.com/processing/p5.js-web-editor/pull/2376, since it was raised first! In that vein, I'm going to close this one for now, but maybe some changes here could also be referenced in the other one as well?