processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.
https://editor.p5js.org
GNU Lesser General Public License v2.1
1.32k stars 1.27k forks source link

No password confirmation when resetting a password #2975

Closed Keshav-0907 closed 1 month ago

Keshav-0907 commented 5 months ago

Increasing Access

Adding a Confirm Password field when resetting password in the p5.js Web Editor will :

Feature request details

When reseting password through User Settings, their should be a confirm new password field which will help in confirming the new password.

This will ensure enhanced security and user experience by minimizing the likelihood of any mistypes in the new password by the user.

Screenshot 2024-01-29 at 4 02 25 AM

I want to work in this issue

aniketjat03 commented 5 months ago

@lindapaiste Can you please assign this issue to me. I am thinking to solve this issue by adding a new input field for Confirm new password here, and add validation in the respected backend controller to check both input passwords are same. thanks!

raclim commented 5 months ago

Hmm, I'm personally not sure if this might be needed here but I might be biased towards having less page elements in general! I'm okay with adding this if having this is a recommended best practice. I'm wondering if adding an eye icon (https://github.com/processing/p5.js-web-editor/issues/2466) could be an alternative for addressing this as well?

Keshav-0907 commented 5 months ago

I could not find any article/report regarding the best practice for this case, but now i also think adding a eye icon should be preferred because having a Confirm Password Field is also hiding the "Social Login" section on majority of the devices.

Screenshot 2024-02-02 at 3 06 03 AM
raclim commented 1 month ago

Closing due to reasons laid out in associated PRs!