Added Show/Hide Toogle to Password Field

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.

https://editor.p5js.org

GNU Lesser General Public License v2.1

1.3k stars 1.27k forks source link

Added Show/Hide Toogle to Password Field #2981

Closed Keshav-0907 closed 3 weeks ago

Keshav-0907 commented 5 months ago

Fixes #2975

Changes:

Added a Password toggle, to toggle between 'show' & 'hide' as per user input,

https://github.com/processing/p5.js-web-editor/assets/91189139/a31b8584-e923-46ec-b9fa-e0ea7e16a0e3

I have verified that this pull request:

[x] has no linting errors (npm run lint)
[x] has no test errors (npm run test)
[x] is from a uniquely-named feature branch and is up to date with the develop branch.
[x] is descriptively named and links to an issue number, i.e. Fixes #2975

raclim commented 3 weeks ago

Thanks for your work on this! I think we discussed this in the issue, but I think this PR would be great if it had the eye icon, especially since we just merged in a PR (https://github.com/processing/p5.js-web-editor/pull/2467) that utilizes it. Since it's fallen a bit out of sync, I'm going to close this for now. I'm sorry that we couldn't get this in, but please feel free to reopen this PR with its updates or check out the other issues!