search

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.
https://editor.p5js.org
GNU Lesser General Public License v2.1
1.3k stars 1.27k forks source link

Missing ending quotation mark to "Added to [collection]" toast #3021

Closed pie999 closed 4 months ago

pie999 commented 4 months ago

p5.js version

v1.9.0

What is your operating system?

Windows

Web browser and version

Firefox 122.0.1

Actual Behavior

The ending quotation mark is missing from the "Added to [collection]" toast. https://github.com/processing/p5.js-web-editor/blob/6cac275429c3911d87afdcdbbdbf185092aeac29/client/modules/IDE/actions/collections.js#L83

Expected Behavior

There should be a quotation mark after ${collectionName}.

Steps to reproduce

Add a sketch to a collection.

welcome[bot] commented 4 months ago

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

aditya3011ai commented 4 months ago

Hi @pie999 , I would like to work on this Bug could you please assign it to me.

lindapaiste commented 4 months ago

This is definitely a mistake. But also, we really should migrate all three of those texts to our translation system. They are not getting translated at all right now.

https://github.com/processing/p5.js-web-editor/blob/6cac275429c3911d87afdcdbbdbf185092aeac29/client/modules/IDE/actions/collections.js#L50 https://github.com/processing/p5.js-web-editor/blob/6cac275429c3911d87afdcdbbdbf185092aeac29/client/modules/IDE/actions/collections.js#L83 https://github.com/processing/p5.js-web-editor/blob/6cac275429c3911d87afdcdbbdbf185092aeac29/client/modules/IDE/actions/collections.js#L113