Fixed issue #2492 comfirmation before loggingout

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.

https://editor.p5js.org

GNU Lesser General Public License v2.1

1.3k stars 1.26k forks source link

Fixed issue #2492 comfirmation before loggingout #3033

Closed PiyushThapaa closed 2 months ago

PiyushThapaa commented 4 months ago

Fixes #2492

Changes: Instead of making a confirmation modal, I simply add a confirmation pop up before loggingout because there is no modal for any other confirmation, all uses confirmation pop up.

I have verified that this pull request:

[x] has no linting errors (npm run lint)
[x] has no test errors (npm run test)
[x] is from a uniquely-named feature branch and is up to date with the develop branch.
[x] is descriptively named and links to an issue number, i.e. Fixes #2492

raclim commented 2 months ago

Thanks for working on this! I'm going to close this due to reasons outlined in https://github.com/processing/p5.js-web-editor/issues/2492#issuecomment-2073008417.