Udpated : Passport handles expected errors as exceptions

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.

https://editor.p5js.org

GNU Lesser General Public License v2.1

1.3k stars 1.26k forks source link

Udpated : Passport handles expected errors as exceptions #3045

Closed SjxSubham closed 4 months ago

SjxSubham commented 4 months ago

Fixes #3044

Changes: Line 126 inside done()

I have verified that this pull request:

[x] has no linting errors (npm run lint)
[x] has no test errors (npm run test)
[x] is from a uniquely-named feature branch and is up to date with the develop branch.
[x] is descriptively named and links to an issue number, i.e. Fixes #3044

welcome[bot] commented 4 months ago

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

lindapaiste commented 4 months ago

This is good by my intention was to change all similar lines too, not just the one line that I pointed out. I'm closing this in favor of #3049