Fix: Logout error modal popping up on downloading other users' sketch…

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.

https://editor.p5js.org

GNU Lesser General Public License v2.1

1.3k stars 1.26k forks source link

Fix: Logout error modal popping up on downloading other users' sketch… #3073

Closed NishantBansal2003 closed 1 month ago

NishantBansal2003 commented 3 months ago

Fixes #3053

Changes: This update improves the 'downloadSketch' function by adding validation checks. It ensures that projects are only saved when the logged-in user owns them, reducing unnecessary API requests and enhancing the user experience.

I have verified that this pull request:

[x] has no linting errors (npm run lint)
[x] has no test errors (npm run test)
[x] is from a uniquely-named feature branch and is up to date with the develop branch.
[x] is descriptively named and links to an issue number, i.e. Fixes #3053

welcome[bot] commented 3 months ago

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

release-com[bot] commented 3 months ago

Release Environments

This Environment is provided by Release, learn more! To see the status of the Environment click on Environment Status below.

p5.js-web-editor
- app-ted0d79.release.editor.p5js.org/
- preview-ted0d79.release.editor.p5js.org/

:wrench:Environment Status : https://app.release.com/public/Processing%20Foundation/env-083ad3c08f

raclim commented 1 month ago

Thanks for your work on this! This ultimately ended up getting addressed by #3116, so I'm going to close this PR. I'm sorry that we couldn't get this in, but please feel free to check out our other issues!