Made the Logo of P5 redirect to users sketches, Fixes #3083

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.

https://editor.p5js.org

GNU Lesser General Public License v2.1

1.36k stars 1.32k forks source link

Made the Logo of P5 redirect to users sketches, Fixes #3083 #3092

Closed sriganeshres closed 4 months ago

sriganeshres commented 5 months ago

Fixes #3083

https://github.com/processing/p5.js-web-editor/assets/120654479/2ae8c559-3a70-47cc-94b0-0d717b86e989

Changes:

I have verified that this pull request:

[x] has no linting errors (npm run lint)
[x] has no test errors (npm run test)
[x] is from a uniquely-named feature branch and is up to date with the develop branch.
[x] is descriptively named and links to an issue number, i.e. Fixes #3083

welcome[bot] commented 5 months ago

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

release-com[bot] commented 5 months ago

Release Environments

This Environment is provided by Release, learn more! To see the status of the Environment click on Environment Status below.

p5.js-web-editor
- app-tede634.release.editor.p5js.org/
- preview-tede634.release.editor.p5js.org/

:wrench:Environment Status : https://app.release.com/public/Processing%20Foundation/env-b2eb0472ac

raclim commented 5 months ago

Thanks for opening this PR!

I feel like it looks good so far! One extra change I might make is that the aria-label should be updated to indicate that this logo redirects to a user's sketch. I think it could help to try to do some screen reader testing here too to confirm this!

raclim commented 4 months ago

Due to the amount of time that's passed, I'm going to close this PR for now, but please feel free to reopen a new one with the requested changes, thanks!