processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.
https://editor.p5js.org
GNU Lesser General Public License v2.1
1.3k stars 1.26k forks source link

bug: The t&c line of signup page for japanese language is still in english. #3102

Closed nishikant23 closed 1 month ago

nishikant23 commented 2 months ago

p5.js version

2.19.9

What is your operating system?

Windows

Web browser and version

chrome/brave

Actual Behavior

It is not translating to japanese.

p5js_jap_wo_jap_warning

Expected Behavior

It should be translated to japanese.,like below img.

p5js_jap_warning

I have translated to cloned repo of this, also get confirmed with my japanese friend the provided japanes-translation is in correct grammar usage.

Steps to reproduce

Steps to find error:

1.open p5.js web editor 2.Click of "sign up" button 3.Select any language other than "English",for example "Japanese" 4.Observe the error that mention above

welcome[bot] commented 2 months ago

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

raclim commented 2 months ago

Thanks for sharing this! Could you also add a text version of the Japanese translation into your description, so the translation can be read outside of the image as well?

Shrijan125 commented 1 month ago

@raclim I would like to work on this issue. Can you assign me?

nishikant23 commented 1 month ago

@raclim please check my open PR to merge, thanks.