refactor console reducers and actions using redux toolkit

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.

https://editor.p5js.org

GNU Lesser General Public License v2.1

1.3k stars 1.26k forks source link

refactor console reducers and actions using redux toolkit #3119

Closed PiyushChandra17 closed 2 weeks ago

PiyushChandra17 commented 1 month ago

Associated issue: #2042

Changes:

First things first removed all the associated constants
Used createSlice to rewrite the console reducer
Exported the automatically generated action creator functions from actions/console.js
Deleted the existing action creator function

I have verified that this pull request:

[x] has no linting errors (npm run lint)
[x] has no test errors (npm run test)
[x] is from a uniquely-named feature branch and is up to date with the develop branch.
[x] is descriptively named and links to an issue number, i.e. Fixes #123

raclim commented 3 weeks ago

Thanks for your work on this! I'm skimming over this at the moment so I'm sorry that my feedback isn't very specific, but while running this branch I noticed that a few errors pop up when I try to run my sketch.

PiyushChandra17 commented 3 weeks ago

Thanks for your work on this! I'm skimming over this at the moment so I'm sorry that my feedback isn't very specific, but while running this branch I noticed that a few errors pop up when I try to run my sketch.

Sure, I'll take a look at this one, and try fixing that few errors, probably push the new changes to this branch super soon!

PiyushChandra17 commented 3 weeks ago

@raclim I think i have fixed the errors being popped up while running the sketch, can you please check?