processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.
https://editor.p5js.org
GNU Lesser General Public License v2.1
1.36k stars 1.32k forks source link

fixed the issue 1852 #3198

Closed TUSHAR1651 closed 2 months ago

TUSHAR1651 commented 2 months ago

Fixes #issue-number 1852

Changes:

I have verified that this pull request:

TUSHAR1651 commented 2 months ago

I have the fixed the issue in this PR on using the dark mode the text colour was not looking good so i trued to change it

raclim commented 2 months ago

Thanks so much for your work on this!

Although this PR does accomplish the issue of darker text not appearing on dark mode, it also seems to affect the background of the other themes as well. Ideally, this should be isolated to just the Dark and High Contrast themes. Due to this, I also feel that these changes should also be more dependent on when the theme is changed. There also seems to be an additional change to the Dockerfile, which I feel might not be related to this issue—ideally we would like to keep these types of changes to a minimum!

Overall though, I know that what the solution for this issue should look like isn't very clear yet at the moment 😅—I've been hoping to find one that could elegantly implement this without it looking too visually out of place. Due to some of the issues listed above I don't think we'll be merging this in for now—I'm sorry that we couldn't get this in, but please feel free to continue brainstorming on what the solution for this could look like!