React component conversion(class to functional) - 1

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.

https://editor.p5js.org

GNU Lesser General Public License v2.1

1.36k stars 1.32k forks source link

React component conversion(class to functional) - 1 #3208

Open nahbee10 opened 1 month ago

nahbee10 commented 1 month ago

Fixes #2709

Changes:

converted IDE/components/Editor/index.jsx to use React functional component

I have verified that this pull request:

[x] has no linting errors (npm run lint)
[x] has no test errors (npm run test)
[x] is from a uniquely-named feature branch and is up to date with the develop branch.
[x] is descriptively named and links to an issue number, i.e. Fixes #123

welcome[bot] commented 1 month ago

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

release-com[bot] commented 1 month ago

Release Environments

This Environment is provided by Release, learn more! To see the status of the Environment click on Environment Status below.

p5.js-web-editor
- app-tedcbd5.release.editor.p5js.org/
- preview-tedcbd5.release.editor.p5js.org/

:wrench:Environment Status : https://app.release.com/public/Processing%20Foundation/env-3a3542f66b

khanniie commented 1 month ago

Left a few comments but overall looks great! : D thanks nahee!

khanniie commented 1 month ago

When I test the staging link, something kind of crazy happens when i hit tidy code :O

khanniie commented 1 month ago

I think we may have lost the error highlighting as well -- left is this branch and right is what's live

raclim commented 1 month ago

Just to add, I'm on the staging environment and am having trouble switching between different files in the left-hand navigation as well!

https://github.com/user-attachments/assets/636f4ea2-35d1-4ffe-acb4-75200942396f