#3206 when selecting other languages english wasnt preffered at first

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.

https://editor.p5js.org

GNU Lesser General Public License v2.1

1.4k stars 1.35k forks source link

#3206 when selecting other languages english wasnt preffered at first #3213

Closed kavyathegreat closed 3 months ago

kavyathegreat commented 3 months ago

Fixes processing/p5.js#7168

Changes: made LanguageSelector file in components that will give prefernce to english when other languages are selected Made a new file LanguageSelector and added functionality as english language preffered over other when different languages are chosen I have verified that this pull request:

[ ] has no linting errors (npm run lint)
[ ] has no test errors (npm run test)
[ ] is from a uniquely-named feature branch and is up to date with the develop branch.
[ ] is descriptively named and links to an issue number, i.e. Fixes processing/p5.js-web-editor#123

welcome[bot] commented 3 months ago

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

release-com[bot] commented 3 months ago

Release Environments

This Environment is provided by Release, learn more! To see the status of the Environment click on Environment Status below.

p5.js-web-editor
- app-ted5c7e.release.editor.p5js.org/
- preview-ted5c7e.release.editor.p5js.org/

:wrench:Environment Status : https://app.release.com/public/Processing%20Foundation/env-615daf3557

raclim commented 3 months ago

Thanks for submitting this! I just want to note that there are no visible file changes for this pull request. Would you be able to update this PR so that your changes are visible?

kavyathegreat commented 3 months ago

Yes sure

On Thu, 8 Aug 2024, 11:24 pm raclim, @.***> wrote:

Thanks for submitting this! I just want to note that there are no visible file changes for this pull request. Would you be able to update this PR so that your changes are visible?

— Reply to this email directly, view it on GitHub https://github.com/processing/p5.js-web-editor/pull/3213#issuecomment-2276365933, or unsubscribe https://github.com/notifications/unsubscribe-auth/BDTAMSS42TMXUOSCHKKVZ5LZQOWG7AVCNFSM6AAAAABMF2KNSOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZWGM3DKOJTGM . You are receiving this because you authored the thread.Message ID: @.***>