search

processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.
https://editor.p5js.org
GNU Lesser General Public License v2.1
1.36k stars 1.32k forks source link

The upload file button will be disabled after reaching the limit 250MB #3219

Closed Noorain464 closed 1 month ago

Noorain464 commented 1 month ago

Fixes #issue-number: Error message claiming size limit of 250MB reached #2080 Changes:

I have verified that this pull request:

raclim commented 1 month ago

Thanks so much for your work on this!

After reviewing this, it seems like you're trying to add an alert message once a user has reached the 250MB limit for storing assets. We do have error handling for this implemented already in the File Upload Modal (UploadFileModal.jsx), although I do think it could be interesting to explore using an alert instead or doing this in the sidebar navigation!

I don't think the overall changes here are addressing the original issue, but I've left a few notes on what's here so far! I feel that the original issue seems to involve how the asset sizes are being determined, so it might be better to try working from there instead. I'm going to close this pull request for now, but please feel free to revisit this with any updates!