processing / p5.js-web-editor

The p5.js Editor is a website for creating p5.js sketches, with a focus on making coding accessible and inclusive for artists, designers, educators, beginners, and anyone else! You can create, share, or remix p5.js sketches without needing to download or configure anything.
https://editor.p5js.org
GNU Lesser General Public License v2.1
1.36k stars 1.32k forks source link

The Error message is not being Translated to selected Language #3229

Open Ganeshvarikuppala opened 3 weeks ago

Ganeshvarikuppala commented 3 weeks ago

p5.js version

No response

What is your operating system?

None

Web browser and version

No response

Actual Behavior

It is not getting translated Pj5

Expected Behavior

It should be translated

Steps to reproduce

Steps:

  1. Go to Sign Up page 2.Select language 3.Enter the invalid inputs 4.You will get a error message displayed. 5.Now select another language. 6.Everything will be translated except Error message
welcome[bot] commented 3 weeks ago

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

Serena20003 commented 3 weeks ago

Hi, I think the issue here is that because the error message gets re-populated only after the user has "touched" the input field, which means that they need to enter the text field, then leave the text field for the error message to re-populate. This can be seen in line 79 of client/modules/User/components/SignupForm.js: {field.meta.touched && field.meta.error && ( Perhaps one way to work around it is to change field.meta.touched to something else that doesn't require the user to enter and leave the textfield again after changing the language (perhaps field.meta.invalid?). The number of translations on translations/locales/hi/translations.json match the number on translations/locales/hi/translations.json for ReduxFormUtils, which I believe is controlling the translations for error messages for the signup form fields. I did notice one missing translation for "This username is already taken." though. Screenshot 2024-09-08 at 2 25 46 PM

AbhigyanSrivastav commented 1 week ago

Hey can i work on this issue?