search

processing / p5.js-website-legacy

Archived p5.js website 2015-2024
http://archive.p5js.org
MIT License
240 stars 484 forks source link

Missing save button and brush size slider #1478

Closed Hemant2A2 closed 8 months ago

Hemant2A2 commented 9 months ago

Most appropriate sections of the p5.js website?

Examples

What is your operating system?

Mac OS

Web browser and version

Chrome , Version 120.0.6099.109 (Official Build) (arm64)

Actual Behavior

Screenshot 2023-12-29 at 2 53 31 PM

The description here mentions the save and clear buttons and brush size slider, but none are visible on the website.

Expected Behavior

The save button and brush size slider should be made functional on the website. A clear screen button may not be needed as the reset button has the same purpose.

Steps to reproduce

Go to https://p5js.org/examples/interaction-kaleidoscope.html

Would you like to work on the issue?

Yes , I'd like to work on this issue

limzykenneth commented 8 months ago

@Hemant2A2 You can go ahead and look into this, although it might not be very striaghtforward due to the way examples are rendered on the website. You might want to consider just removing the functionalities of changing brush size etc instead.

Hemant2A2 commented 8 months ago

@limzykenneth When I run the same code in the editor the buttons are present there, so I don't think we should remove the functionalities. Instead, we should change the description on the website.

limzykenneth commented 8 months ago

Sure, you can go ahead and we can review in a PR.