Update Getting Started text editor recommendations

processing / p5.js-website-legacy

Archived p5.js website 2015-2024

http://archive.p5js.org

MIT License

241 stars 490 forks source link

Update Getting Started text editor recommendations #1493

Closed joenash closed 4 months ago

joenash commented 6 months ago

Fixes #1492

Changes:

Replaced Atom with Visual Studio Code
Updated Sublime Text 2 to just "Sublime Text", with a link to the generic download page

Todo:

Confirm that Visual Studio Code is an acceptable addition via the discussion in #1492
Check that the Sublime Text setup instructions lower in the document still apply to Sublime Text

joenash commented 6 months ago

Hey @nickmcintyre,

I've made those changes, I do have questions about the i18n handling though. I removed environment blocks 5-7 in index.hbs, but wasn't sure if I should remove the corresponding entries in en.yml, or update the numbering scheme, as I didn't want to cause issues for the other translations.

I guess given the upcoming docs revamp that having some redundant lines lurking in the en.yml isn't the end of the world, but wanted to flag it just in case!

joenash commented 5 months ago

Sorry for the delay @nickmcintyre, this should be done now!

limzykenneth commented 4 months ago

@joenash @nickmcintyre Is this ready for merge?

nickmcintyre commented 4 months ago

@limzykenneth nope, translations are still broken (missing links in the middle of sentences). Restoring the other editors to templates/pages/get-started/index.hbs fixes the translations but breaks English (links to other editors appear out of context).

@joenash I suggest we close this issue in keeping with #1452. I'm sorry this fix wasn't as straightforward as I thought. The new p5.js website will be launched in a couple of months and there will countless opportunities to contribute!

joenash commented 4 months ago

Sounds good, thanks @nickmcintyre. No need to apologise, sorry for taking up your time with reviewing this, I wasn't very familiar with the translation system going in and I should have checked what was happening there before opening the PR. Looking forward to the new site!