Open connieliu0 opened 4 years ago
Can the locale code for Chinese be changed from just zh
to zh-Hans
to denote Simplified Chinese as opposed to Traditional Chinese? (They are different script basically)
Hi @limzykenneth Just renamed zh to zh_Hans and pushed to master!
A small thing but can the underscore be changed to a hyphen (zh_Hans
> zh-Hans
) to match the language code standards. If it caused unintended problems then it's fine to leave as is.
I tried to name is zh-Hans, but I don't think that's allowed w/ react-i18next bc I got an error
@yining1023 @montoyamoraga
Hi all! I finished editing all the entries so they are ready to be translated. Thank you for the patience! Feel free to tag anyone who'd be interested in helping :). Also I'm hoping to have it deployed by the second week of September, let me know if there are any problems.
Also, the only parts that need to be translated are keys before "filters" (which is around line 39) and for all the entries under showcase2020, only the description key needs to be translated. extradesc does not need to be translated nor do any of the other keys under each showcase entry.
Below in this picture, the pink box is around the key that needs to be translated in each entry.
Thank you all so much for the help :^D
@connieliu0, thank you for finalizing all the English text!
I added some Chinese translation and opened a PR here: https://github.com/connieliu0/p5.js-showcase/pull/8
I translated all the keys before "filters". I didn't get a chance to translate descriptions for each 2020 project. Maybe we could find more help from others who are interested to help.
hi @connieliu0 here is my PR too :) https://github.com/connieliu0/p5.js-showcase/pull/9
@yining1023 @montoyamoraga thank you all for helping!!!
Context: Hi all! My name is Connie and I'm currently working with p5.js as part of Google Summer of Code! I am planning to add translations to the 2020 showcase, and below are instructions on how to add translations. Currently the translation files for the p5.js Summer 2020 showcase are seen here: https://github.com/connieliu0/p5.js-showcase/tree/master/src/locales and for each language the translation.json is found under the respective language name folder. Then the process of translating is very similar to the 2019 showcase, basically the values of the keys need to be replaced. More documentation about how the translation structure is set up as a whole can be found here if needed.
Currently I'm hoping to have up to "showcase2019" translated because I'm still working on cleaning up the actual showcase entries.![image](https://user-images.githubusercontent.com/50529223/90289180-58156f00-de49-11ea-9735-3cc37a476907.png)
Because there are so many showcase entries this year, the amount translated will mostly just be the description. Thanks so much for the help and I will make another update to this issue when the showcase entries are ready for translation (this will be within the next two days). Also feel free to tag anyone else who might be able to help! Let me know if there are any issues!
@montoyamoraga @lm-n would it be possible to help out with the preliminary spanish translation? (link here) @yining1023 would it be possible to help out with the preliminary chinese translation? (link here) @joeyklee