processing / p5.js-website

New p5.js website!
http://p5js.org
MIT License
19 stars 89 forks source link

Fix broken links on p5.js website page for "WebGL Contribution Guide" #510

Closed iamniky closed 2 months ago

iamniky commented 2 months ago

Most appropriate sections of the p5.js website?

Contribute

What is your operating system?

Windows

Web browser and version

Firefox v130.0, though would affect all.

Actual Behavior

When users visit the URL https://p5js.org/contribute/webgl_contribution_guide/ and click on the hyperlink that is labeled "contributor guidelines", they are met with a 404 error page:

Screenshot 2024-09-06 003102

Screenshot 2024-09-06 003145

When users visit the URL https://p5js.org/contribute/webgl_contribution_guide/ and click on the hyperlink that is labeled "in a GitHub Project", they are met with a 404 error page:

Screenshot 2024-09-06 003533

Screenshot 2024-09-06 003605

Expected Behavior

We expect that when the users click the hyperlink labeled "contributor guidelines", they are taken to a page with information regarding contributor guidelines.

We expect that when the users click the hyperlink labeled "in a GitHub Project", they are taken to a page with information regarding a GitHub Project.

Steps to reproduce

Steps:

  1. Go to https://p5js.org/contribute/contributing_to_the_p5js_reference/
  2. Click on respective links (listed in table below).
  3. Get a 404 error.

Solution:

Replace listed broken links to the correct links.

Source link text: Current link: Suggested link:
contributor guidelines https://github.com/processing/p5.js/blob/main/contributor_docs/contributor_guidelines/ https://p5js.org/contribute/contributor_guidelines/
in a GitHub Project https://github.com/orgs/processing/projects/5 ???

Would you like to work on the issue?

Yes, I'd like to work on the issue.

iamniky commented 2 months ago

Incorrect URL above under "Steps:"

It should be

Steps:

Go to  https://p5js.org/contribute/webgl_contribution_guide/
Click on respective links (listed in table below).
Get a 404 error.
shourysingh07 commented 2 months ago

I'd like to work on the issue.

Qianqianye commented 2 months ago

Thanks @iamniky for catching the bug and @shourysingh07 for your interest in working on this.

The first link is already fixed in this commit.

The second link 'We organize open issues in a GitHub Project' should go to this link: https://github.com/orgs/processing/projects/20. If you are interested in working on this issue, please edit this line in the p5.js repo contributor_docs/webgl_contribution_guide.md file. Thanks!

shourysingh07 commented 2 months ago

Thank you @Qianqianye ! I've opened a pull request within the p5.js library repo.

Here is the PR Link.

Qianqianye commented 2 months ago

Closing this issue since it's resolved in PR #7263