processing / p5.js-website

New p5.js website!
http://p5js.org
MIT License
19 stars 89 forks source link

Fix text stroke color not the same as the fill color #545

Closed davepagurek closed 2 months ago

davepagurek commented 2 months ago

Resolves https://github.com/processing/p5.js-website/issues/518

It looks like we add a stroke to text to make it bolder. There were a few cases where we would update the fill color of text but not the stroke color, leading to a slight different-colored halo around text. It was happening in links before, see below:

Before:

image

After:

image

That said, it looks like this text stroke may be the cause of https://github.com/processing/p5.js-website/issues/473. I'm not sure how standard this property is, and whether it's a good idea to be using it across the board on body text like this. Possibly a sign that we should just be using a thicker font instead?

Qianqianye commented 2 months ago

Thanks @davepagurek. I'm merging this solution for now, and we can have schedule a chat with the web designer with all the issues and PRs labelled Web Design soon.